際際滷

際際滷Share a Scribd company logo
Code Reviews One Thing Every Programmer Should Know Mattias Karlsson Java Champion, JUG Leader and Agile coach Avega Group Sweden
Disclaimer My own experience I am probably wrong
Bio Twitter: @matkar www.LinkedIn/in/mattiask Mattias Karlsson Java Champion, JUG Leader & Agile coach Avega Group Stockholm Sweden
JUG Stockholm www.jforum.se
Jfokus
Code Reviews One Thing Every Programmer Should Know
油
Why? Increase Quality Reduce Defects Increase Team Spirit
Anti Pattern Photo by dpstyles Architects Review Everything
Pair Programming Photo by dpstyles H Kniberg
Goal Sharing knowledge
Code Reviews Code Review Meeting    (1-2 hour/week) Code Review Day Informal / brown bag style
Reaction
Preparation Code Conventions   (checked by tools) Tested Definition of DONE
Code review meeting Code Walkthrough Introduce Review Roles Have a Moderator Take notes Involve Experts Involve Newbie  s
Mood Learning Mood Open and Respectful Collaborative & Constructive Don卒t be sarcastic! Ask Questions
Watch out for Ego Effect / Hurt Feelings  I have to contribute..  Don卒t Point Out Spelling Errors It卒s all about sharing the code Hint:
Have Fun
Measurement
Thanks! Feedback: #DevoxxCR Mattias Karlsson www.linkedin.com/in/mattiask twitter: @matkar [email_address] 息Copyright 2011

More Related Content

Code Reviews at Devoxx

Editor's Notes

  1. And about measurement... I can only agre with this.. Numbers of WTF/min is a a good indicator and it will hopefully be less of the if you start with code review.
  2. Thanks (and buy the book It has a lot more tips and trix than this)