際際滷

際際滷Share a Scribd company logo
Code Review
Vol .3
31th Wed Aug 2016
Before
Start Code Review
Lets check the
Purpose
Code Review is
a process of mutual learning
 That Reviewers and Reviewees
learn from each other
 Share your ideas/opinion/suggestion !!!
 Learn by question :D
What is
Important?
 Growth means you can understand/categorize what is the
problem
 Growth means you not repeat the same mistake
 Growth means you can improve/find effective way of doing
 Growth means you can teach the other member
What is Growth?
Important thing is
Members Growth
Mindset
Reviewer
 Try to tell your opinion to Reviewee
 Be polite expression as much as possible
 Let praise the good point
 Provide not only the point out but also suggest how to improve it
 Try to improve your code
 Learn from devs technics to write good code
 Keep motivation to write good code
 Dont be afraid to say wrong thing,
we can discuss about it later.
 Don't be afraid to fail!
Its OK we can fail many time
Reviewee
All
11st  3rd Presenter do Code Review
Overview
3 improvement suggestion
2 Enjoy sweets
3 Register the suggestion as task
After finished Code Review, each project PM/You will register the
problem/suggestion to each project's TODO list(ex. Github) as task.
Check Process
Lets Start!!!

More Related Content

What's hot (6)

160210119069
160210119069 160210119069
160210119069
vasu makadiya
Interviews
InterviewsInterviews
Interviews
Kaushik Raghupathi
What is extensive_reading
What is extensive_readingWhat is extensive_reading
What is extensive_reading
Ar Aulamentor
Learning Disabilities and Tutoring Strategies
Learning Disabilities and Tutoring StrategiesLearning Disabilities and Tutoring Strategies
Learning Disabilities and Tutoring Strategies
ArkansasAthleticsTutoring
Self-reviews
Self-reviewsSelf-reviews
Self-reviews
Lo誰c Hervier
Media Training for better client coaching-1
Media Training for better client coaching-1Media Training for better client coaching-1
Media Training for better client coaching-1
James Chung
What is extensive_reading
What is extensive_readingWhat is extensive_reading
What is extensive_reading
Ar Aulamentor
Learning Disabilities and Tutoring Strategies
Learning Disabilities and Tutoring StrategiesLearning Disabilities and Tutoring Strategies
Learning Disabilities and Tutoring Strategies
ArkansasAthleticsTutoring
Media Training for better client coaching-1
Media Training for better client coaching-1Media Training for better client coaching-1
Media Training for better client coaching-1
James Chung

Similar to Code review process (20)

Effective Peer Review
Effective Peer ReviewEffective Peer Review
Effective Peer Review
Joel Hooks
How to successfully grow a code review culture
How to successfully grow a code review cultureHow to successfully grow a code review culture
How to successfully grow a code review culture
Nina Zakharenko
Peer review
Peer reviewPeer review
Peer review
Charuta Joshi
Coding Words, A Practical Guide for Developers Who Want To Become Better Writers
Coding Words, A Practical Guide for Developers Who Want To Become Better WritersCoding Words, A Practical Guide for Developers Who Want To Become Better Writers
Coding Words, A Practical Guide for Developers Who Want To Become Better Writers
Jonathan Bossenger
Code review Effective - kwan
Code review  Effective - kwanCode review  Effective - kwan
Code review Effective - kwan
Thamara Hessel
Exercise 9
Exercise 9Exercise 9
Exercise 9
Rudy Guerrero
10 Faulty Behaviors of Code Review - Developer Summit Istanbul 2018
10 Faulty Behaviors of Code Review - Developer Summit Istanbul 201810 Faulty Behaviors of Code Review - Developer Summit Istanbul 2018
10 Faulty Behaviors of Code Review - Developer Summit Istanbul 2018
Lemi Orhan Ergin
Pair programming
Pair programmingPair programming
Pair programming
Dalal Alrayes
Mentoring l1 session 2 accredited
Mentoring l1 session 2 accreditedMentoring l1 session 2 accredited
Mentoring l1 session 2 accredited
Holly Fairburn
Blogging Tips - A guide to why you should blog
Blogging Tips - A guide to why you should blogBlogging Tips - A guide to why you should blog
Blogging Tips - A guide to why you should blog
Romin Irani
Coaching Conversations
Coaching ConversationsCoaching Conversations
Coaching Conversations
Laura Pasquini
Writing for results, one day course, master slides without notes
Writing for results, one day course, master slides without notesWriting for results, one day course, master slides without notes
Writing for results, one day course, master slides without notes
Scott Keyser
2 Getting Started Planning and Writing Business Messages .docx
2 Getting Started Planning and Writing Business Messages .docx2 Getting Started Planning and Writing Business Messages .docx
2 Getting Started Planning and Writing Business Messages .docx
felicidaddinwoodie
How to successfully grow a code review culture
How to successfullygrow a code review cultureHow to successfullygrow a code review culture
How to successfully grow a code review culture
Danylenko Max
How to Crack a GROUP DISCUSSION: DOs and DONTs of GD
How to Crack a GROUP DISCUSSION: DOs and DONTs of GDHow to Crack a GROUP DISCUSSION: DOs and DONTs of GD
How to Crack a GROUP DISCUSSION: DOs and DONTs of GD
Dr. Aashish Mehra
Entrepreneurship is product management
Entrepreneurship is product managementEntrepreneurship is product management
Entrepreneurship is product management
Andrew Gutierrez
Hidden sides of Code Review (Do-iOS)
Hidden sides of Code Review (Do-iOS)Hidden sides of Code Review (Do-iOS)
Hidden sides of Code Review (Do-iOS)
Dmitrii Ivanov
RHA Leadership Seminar_Final.pptx
RHA Leadership Seminar_Final.pptxRHA Leadership Seminar_Final.pptx
RHA Leadership Seminar_Final.pptx
mercere6
Effective Code Review
Effective Code ReviewEffective Code Review
Effective Code Review
Eyal Kenig
UPDATED - 3 quick wins for managers to love appraisals
UPDATED  - 3 quick wins for managers to love appraisals UPDATED  - 3 quick wins for managers to love appraisals
UPDATED - 3 quick wins for managers to love appraisals
Hedda Bird
Effective Peer Review
Effective Peer ReviewEffective Peer Review
Effective Peer Review
Joel Hooks
How to successfully grow a code review culture
How to successfully grow a code review cultureHow to successfully grow a code review culture
How to successfully grow a code review culture
Nina Zakharenko
Coding Words, A Practical Guide for Developers Who Want To Become Better Writers
Coding Words, A Practical Guide for Developers Who Want To Become Better WritersCoding Words, A Practical Guide for Developers Who Want To Become Better Writers
Coding Words, A Practical Guide for Developers Who Want To Become Better Writers
Jonathan Bossenger
Code review Effective - kwan
Code review  Effective - kwanCode review  Effective - kwan
Code review Effective - kwan
Thamara Hessel
10 Faulty Behaviors of Code Review - Developer Summit Istanbul 2018
10 Faulty Behaviors of Code Review - Developer Summit Istanbul 201810 Faulty Behaviors of Code Review - Developer Summit Istanbul 2018
10 Faulty Behaviors of Code Review - Developer Summit Istanbul 2018
Lemi Orhan Ergin
Mentoring l1 session 2 accredited
Mentoring l1 session 2 accreditedMentoring l1 session 2 accredited
Mentoring l1 session 2 accredited
Holly Fairburn
Blogging Tips - A guide to why you should blog
Blogging Tips - A guide to why you should blogBlogging Tips - A guide to why you should blog
Blogging Tips - A guide to why you should blog
Romin Irani
Coaching Conversations
Coaching ConversationsCoaching Conversations
Coaching Conversations
Laura Pasquini
Writing for results, one day course, master slides without notes
Writing for results, one day course, master slides without notesWriting for results, one day course, master slides without notes
Writing for results, one day course, master slides without notes
Scott Keyser
2 Getting Started Planning and Writing Business Messages .docx
2 Getting Started Planning and Writing Business Messages .docx2 Getting Started Planning and Writing Business Messages .docx
2 Getting Started Planning and Writing Business Messages .docx
felicidaddinwoodie
How to successfully grow a code review culture
How to successfullygrow a code review cultureHow to successfullygrow a code review culture
How to successfully grow a code review culture
Danylenko Max
How to Crack a GROUP DISCUSSION: DOs and DONTs of GD
How to Crack a GROUP DISCUSSION: DOs and DONTs of GDHow to Crack a GROUP DISCUSSION: DOs and DONTs of GD
How to Crack a GROUP DISCUSSION: DOs and DONTs of GD
Dr. Aashish Mehra
Entrepreneurship is product management
Entrepreneurship is product managementEntrepreneurship is product management
Entrepreneurship is product management
Andrew Gutierrez
Hidden sides of Code Review (Do-iOS)
Hidden sides of Code Review (Do-iOS)Hidden sides of Code Review (Do-iOS)
Hidden sides of Code Review (Do-iOS)
Dmitrii Ivanov
RHA Leadership Seminar_Final.pptx
RHA Leadership Seminar_Final.pptxRHA Leadership Seminar_Final.pptx
RHA Leadership Seminar_Final.pptx
mercere6
Effective Code Review
Effective Code ReviewEffective Code Review
Effective Code Review
Eyal Kenig
UPDATED - 3 quick wins for managers to love appraisals
UPDATED  - 3 quick wins for managers to love appraisals UPDATED  - 3 quick wins for managers to love appraisals
UPDATED - 3 quick wins for managers to love appraisals
Hedda Bird

Recently uploaded (20)

UHV UNIT-5 IMPLICATIONS OF THE ABOVE HOLISTIC UNDERSTANDING OF HARMONY ON P...
UHV UNIT-5  IMPLICATIONS OF THE ABOVE HOLISTIC UNDERSTANDING OF HARMONY ON P...UHV UNIT-5  IMPLICATIONS OF THE ABOVE HOLISTIC UNDERSTANDING OF HARMONY ON P...
UHV UNIT-5 IMPLICATIONS OF THE ABOVE HOLISTIC UNDERSTANDING OF HARMONY ON P...
arivazhaganrajangam
MODULE 01 - CLOUD COMPUTING [BIS 613D] .pptx
MODULE 01 - CLOUD COMPUTING [BIS 613D] .pptxMODULE 01 - CLOUD COMPUTING [BIS 613D] .pptx
MODULE 01 - CLOUD COMPUTING [BIS 613D] .pptx
Alvas Institute of Engineering and technology, Moodabidri
Smart wearable device for for health monitering
Smart wearable device for for health moniteringSmart wearable device for for health monitering
Smart wearable device for for health monitering
Venky1435
PCB Design - Top Factors Related to Data Routing and Layout
PCB Design - Top Factors Related to Data Routing and LayoutPCB Design - Top Factors Related to Data Routing and Layout
PCB Design - Top Factors Related to Data Routing and Layout
Epec Engineered Technologies
Kamal 2, new features and practical examples
Kamal 2, new features and practical examplesKamal 2, new features and practical examples
Kamal 2, new features and practical examples
Igor Aleksandrov
4. "Exploring the Role of Lubrication in Machinery Efficiency: Mechanisms, Ty...
4. "Exploring the Role of Lubrication in Machinery Efficiency: Mechanisms, Ty...4. "Exploring the Role of Lubrication in Machinery Efficiency: Mechanisms, Ty...
4. "Exploring the Role of Lubrication in Machinery Efficiency: Mechanisms, Ty...
adityaprakashme26
Mastering Secure Login Mechanisms for React Apps.pdf
Mastering Secure Login Mechanisms for React Apps.pdfMastering Secure Login Mechanisms for React Apps.pdf
Mastering Secure Login Mechanisms for React Apps.pdf
Brion Mario
he Wright brothers, Orville and Wilbur, invented and flew the first successfu...
he Wright brothers, Orville and Wilbur, invented and flew the first successfu...he Wright brothers, Orville and Wilbur, invented and flew the first successfu...
he Wright brothers, Orville and Wilbur, invented and flew the first successfu...
HardeepZinta2
BUILD WITH AI for GDG on campus MVJCE.pptx
BUILD WITH AI for GDG on campus MVJCE.pptxBUILD WITH AI for GDG on campus MVJCE.pptx
BUILD WITH AI for GDG on campus MVJCE.pptx
greeshmadj0
Network analysis and synthesis CH 03-pptx.pptx
Network analysis and synthesis  CH 03-pptx.pptxNetwork analysis and synthesis  CH 03-pptx.pptx
Network analysis and synthesis CH 03-pptx.pptx
GetahunShankoKefeni
DSE8610-Operators-Manual DEEPSEA controller
DSE8610-Operators-Manual DEEPSEA controllerDSE8610-Operators-Manual DEEPSEA controller
DSE8610-Operators-Manual DEEPSEA controller
Sadik74
BCS401 ADA First IA Test Question Bank.pdf
BCS401 ADA First IA Test Question Bank.pdfBCS401 ADA First IA Test Question Bank.pdf
BCS401 ADA First IA Test Question Bank.pdf
VENKATESHBHAT25
REVOLUTIONIZING LEAD QUALIFICATION: THE POWER OF LLMS OVER TRADITIONAL METHODS
REVOLUTIONIZING LEAD QUALIFICATION: THE POWER OF LLMS OVER TRADITIONAL METHODSREVOLUTIONIZING LEAD QUALIFICATION: THE POWER OF LLMS OVER TRADITIONAL METHODS
REVOLUTIONIZING LEAD QUALIFICATION: THE POWER OF LLMS OVER TRADITIONAL METHODS
gerogepatton
Transformer ppt for micro-teaching (2).pptx
Transformer ppt for micro-teaching (2).pptxTransformer ppt for micro-teaching (2).pptx
Transformer ppt for micro-teaching (2).pptx
GetahunShankoKefeni
UHV UNIT-I INTRODUCTION TO VALUE EDUCATION.pptx
UHV UNIT-I INTRODUCTION TO VALUE EDUCATION.pptxUHV UNIT-I INTRODUCTION TO VALUE EDUCATION.pptx
UHV UNIT-I INTRODUCTION TO VALUE EDUCATION.pptx
arivazhaganrajangam
"Introduction to VLSI Design: Concepts and Applications"
"Introduction to VLSI Design: Concepts and Applications""Introduction to VLSI Design: Concepts and Applications"
"Introduction to VLSI Design: Concepts and Applications"
GtxDriver
Supervised Learning Ensemble Techniques Machine Learning
Supervised Learning Ensemble Techniques Machine LearningSupervised Learning Ensemble Techniques Machine Learning
Supervised Learning Ensemble Techniques Machine Learning
ShivarkarSandip
OFFICE AUTOMATION USING ESP32 AND ESP RAINMAKER
OFFICE AUTOMATION USING ESP32 AND ESP RAINMAKEROFFICE AUTOMATION USING ESP32 AND ESP RAINMAKER
OFFICE AUTOMATION USING ESP32 AND ESP RAINMAKER
AdityaSK5
Petrochemical-Processes-Handbook and PE.pdf
Petrochemical-Processes-Handbook and PE.pdfPetrochemical-Processes-Handbook and PE.pdf
Petrochemical-Processes-Handbook and PE.pdf
MustafaAhsan7
Reinventando el CD_ Unificando Aplicaciones e Infraestructura con Crossplane-...
Reinventando el CD_ Unificando Aplicaciones e Infraestructura con Crossplane-...Reinventando el CD_ Unificando Aplicaciones e Infraestructura con Crossplane-...
Reinventando el CD_ Unificando Aplicaciones e Infraestructura con Crossplane-...
Alberto Lorenzo
UHV UNIT-5 IMPLICATIONS OF THE ABOVE HOLISTIC UNDERSTANDING OF HARMONY ON P...
UHV UNIT-5  IMPLICATIONS OF THE ABOVE HOLISTIC UNDERSTANDING OF HARMONY ON P...UHV UNIT-5  IMPLICATIONS OF THE ABOVE HOLISTIC UNDERSTANDING OF HARMONY ON P...
UHV UNIT-5 IMPLICATIONS OF THE ABOVE HOLISTIC UNDERSTANDING OF HARMONY ON P...
arivazhaganrajangam
Smart wearable device for for health monitering
Smart wearable device for for health moniteringSmart wearable device for for health monitering
Smart wearable device for for health monitering
Venky1435
PCB Design - Top Factors Related to Data Routing and Layout
PCB Design - Top Factors Related to Data Routing and LayoutPCB Design - Top Factors Related to Data Routing and Layout
PCB Design - Top Factors Related to Data Routing and Layout
Epec Engineered Technologies
Kamal 2, new features and practical examples
Kamal 2, new features and practical examplesKamal 2, new features and practical examples
Kamal 2, new features and practical examples
Igor Aleksandrov
4. "Exploring the Role of Lubrication in Machinery Efficiency: Mechanisms, Ty...
4. "Exploring the Role of Lubrication in Machinery Efficiency: Mechanisms, Ty...4. "Exploring the Role of Lubrication in Machinery Efficiency: Mechanisms, Ty...
4. "Exploring the Role of Lubrication in Machinery Efficiency: Mechanisms, Ty...
adityaprakashme26
Mastering Secure Login Mechanisms for React Apps.pdf
Mastering Secure Login Mechanisms for React Apps.pdfMastering Secure Login Mechanisms for React Apps.pdf
Mastering Secure Login Mechanisms for React Apps.pdf
Brion Mario
he Wright brothers, Orville and Wilbur, invented and flew the first successfu...
he Wright brothers, Orville and Wilbur, invented and flew the first successfu...he Wright brothers, Orville and Wilbur, invented and flew the first successfu...
he Wright brothers, Orville and Wilbur, invented and flew the first successfu...
HardeepZinta2
BUILD WITH AI for GDG on campus MVJCE.pptx
BUILD WITH AI for GDG on campus MVJCE.pptxBUILD WITH AI for GDG on campus MVJCE.pptx
BUILD WITH AI for GDG on campus MVJCE.pptx
greeshmadj0
Network analysis and synthesis CH 03-pptx.pptx
Network analysis and synthesis  CH 03-pptx.pptxNetwork analysis and synthesis  CH 03-pptx.pptx
Network analysis and synthesis CH 03-pptx.pptx
GetahunShankoKefeni
DSE8610-Operators-Manual DEEPSEA controller
DSE8610-Operators-Manual DEEPSEA controllerDSE8610-Operators-Manual DEEPSEA controller
DSE8610-Operators-Manual DEEPSEA controller
Sadik74
BCS401 ADA First IA Test Question Bank.pdf
BCS401 ADA First IA Test Question Bank.pdfBCS401 ADA First IA Test Question Bank.pdf
BCS401 ADA First IA Test Question Bank.pdf
VENKATESHBHAT25
REVOLUTIONIZING LEAD QUALIFICATION: THE POWER OF LLMS OVER TRADITIONAL METHODS
REVOLUTIONIZING LEAD QUALIFICATION: THE POWER OF LLMS OVER TRADITIONAL METHODSREVOLUTIONIZING LEAD QUALIFICATION: THE POWER OF LLMS OVER TRADITIONAL METHODS
REVOLUTIONIZING LEAD QUALIFICATION: THE POWER OF LLMS OVER TRADITIONAL METHODS
gerogepatton
Transformer ppt for micro-teaching (2).pptx
Transformer ppt for micro-teaching (2).pptxTransformer ppt for micro-teaching (2).pptx
Transformer ppt for micro-teaching (2).pptx
GetahunShankoKefeni
UHV UNIT-I INTRODUCTION TO VALUE EDUCATION.pptx
UHV UNIT-I INTRODUCTION TO VALUE EDUCATION.pptxUHV UNIT-I INTRODUCTION TO VALUE EDUCATION.pptx
UHV UNIT-I INTRODUCTION TO VALUE EDUCATION.pptx
arivazhaganrajangam
"Introduction to VLSI Design: Concepts and Applications"
"Introduction to VLSI Design: Concepts and Applications""Introduction to VLSI Design: Concepts and Applications"
"Introduction to VLSI Design: Concepts and Applications"
GtxDriver
Supervised Learning Ensemble Techniques Machine Learning
Supervised Learning Ensemble Techniques Machine LearningSupervised Learning Ensemble Techniques Machine Learning
Supervised Learning Ensemble Techniques Machine Learning
ShivarkarSandip
OFFICE AUTOMATION USING ESP32 AND ESP RAINMAKER
OFFICE AUTOMATION USING ESP32 AND ESP RAINMAKEROFFICE AUTOMATION USING ESP32 AND ESP RAINMAKER
OFFICE AUTOMATION USING ESP32 AND ESP RAINMAKER
AdityaSK5
Petrochemical-Processes-Handbook and PE.pdf
Petrochemical-Processes-Handbook and PE.pdfPetrochemical-Processes-Handbook and PE.pdf
Petrochemical-Processes-Handbook and PE.pdf
MustafaAhsan7
Reinventando el CD_ Unificando Aplicaciones e Infraestructura con Crossplane-...
Reinventando el CD_ Unificando Aplicaciones e Infraestructura con Crossplane-...Reinventando el CD_ Unificando Aplicaciones e Infraestructura con Crossplane-...
Reinventando el CD_ Unificando Aplicaciones e Infraestructura con Crossplane-...
Alberto Lorenzo

Code review process

  • 1. Code Review Vol .3 31th Wed Aug 2016
  • 2. Before Start Code Review Lets check the Purpose
  • 3. Code Review is a process of mutual learning That Reviewers and Reviewees learn from each other Share your ideas/opinion/suggestion !!! Learn by question :D
  • 5. Growth means you can understand/categorize what is the problem Growth means you not repeat the same mistake Growth means you can improve/find effective way of doing Growth means you can teach the other member What is Growth? Important thing is Members Growth
  • 7. Reviewer Try to tell your opinion to Reviewee Be polite expression as much as possible Let praise the good point Provide not only the point out but also suggest how to improve it Try to improve your code Learn from devs technics to write good code Keep motivation to write good code Dont be afraid to say wrong thing, we can discuss about it later. Don't be afraid to fail! Its OK we can fail many time Reviewee All
  • 8. 11st 3rd Presenter do Code Review Overview 3 improvement suggestion 2 Enjoy sweets 3 Register the suggestion as task After finished Code Review, each project PM/You will register the problem/suggestion to each project's TODO list(ex. Github) as task. Check Process