端端舝

完我扼找抑快
unit-找快扼找抑

What makes a clean test?
Three things. Readability, readability, and readability.
Robert C. Martin, ?Clean Code?

- (void)testLoadAlbums {
NSError *err1 = [NSError errorWithDomain:@"" code:123 userInfo:nil];
OCMStub([self.provider getAlbumsWithResultBlock:OCMOCK_ANY]).andDo(block);
[self waitForExpectationsWithTimeout:1. handler:^(NSError *localError) {
OCMVerify([self.provider getAlbumsWithResultBlock:OCMOCK_ANY]);
}];
}
4

}];
}
5

}];
}
6

}];
}
7

- (void)testDeletingMessages {
NSMutableArray *messages = [NSMutableArray new];
NSManagedObjectContext *ctx = [NSManagedObjectContext MR_contextForCurrentThread];
[messages addObject:message];
}
XCTestExpectation *expectation = [self expectationWithDescription:
[NSString stringWithFormat:@"%s", __PRETTY_FUNCTION__]];
[self.service deleteMessages:messages withResultBlock:^(NSError *error) {
[expectation fulfill];
}];
}
8

}
}];
}
9

}
}];
}
10

}
}];
}
11

妝忘折快技扶批忪扶抑折我扼找抑快找快扼找抑
妞忘抗扭我扼忘找抆折我扼找抑快找快扼找抑
妓快扳忘抗找抉把我技找快扼找
12

13

/**
@author Egor Tolstoy
妙快找抉忱志抉戒志把忘投忘快找戒忘抗快扮我把抉志忘扶扶抑快把快戒批抖抆找忘找抑扭抉我扼抗忘忱抖攸抉扭把快忱快抖快扶扶抉抄
扭抉我扼抗抉志抉抄扼找把抉抗我
@param searchTerm 妤抉我扼抗抉志忘攸扼找把抉抗忘
@return 妓快戒批抖抆找忘找抑扭抉我扼抗忘
*/
- (NSArray *)obtainSearchResultsForSearchTerm:(NSString *)searchTerm;
15

@implementation PeopleServiceImplementationTests
- (void)testThatService {
}
}
}
}
@end
16

}
}
}
}
@end
17

}
}
}
}
@end
18

}
}
}
}
@end
19

}
}
}
}
@end
20

/**
妙快找抉忱志抉戒志把忘投忘快找戒忘抗快扮我把抉志忘扶扶抑快把快戒批抖抆找忘找抑扭抉我扼抗忘忱抖攸抉扭把快忱快抖快扶扶抉抄
扭抉我扼抗抉志抉抄扼找把抉抗我
@param searchTerm 妤抉我扼抗抉志忘攸扼找把抉抗忘
@return 妓快戒批抖抆找忘找抑扭抉我扼抗忘
*/
+
...ServiceReturnsCachedSearchResultsForCorrectQuery
...ServiceReturnsNilWhenNoResults
...ServiceReturnsNilForInvalidCharacters
...ServiceInterpretsDashesAsUnderscores
21

坐把攸戒扶抑快找快扼找抑 > 妥攸忪快抖抉扭抉忱忱快把忪我志忘找抆 >
孝忱忘抖快扶我快找快扼找抉志 > 妤忘忱忘快找抗忘折快扼找志抉扭把抉快抗找忘
22

23

24

25

26

完我扼找抑抄找快扼找
扭把快忱技快找扶抉-抉把我快扶找我把抉志忘扶扶抑抄攸戒抑抗
忌快戒抖我扮扶快忍抉抗抉扶找快抗扼找忘
找快扼找我把批快找扼攸抉忱扶抉扭抉志快忱快扶我快扼我扼找快技抑
27

妤把快忱技快找扶抉-抉把我快扶找我把抉志忘扶扶抑抄攸戒抑抗
孚抉把抉扮抉
XCTAssertEqualObjects(testAlbumError, expectedError);
- (void)testThatServiceReturnsNilWhenNoResults
[self setupStateWithBlockedUser];
妤抖抉抒抉
XCTAssertEqualObjects(err1, err2);
- (void)testNil
[self setupTestData];
28

妖快找抖我扮扶快忍抉抗抉扶找快抗扼找忘
孚抉把抉扮抉
[self stubServiceCompletionBlockWithError:error];
- (void)setUp {}
妤抖抉抒抉
...[invocation getArgument:&result atIndex:3];...
... self.interactor.output = OCMProtocolMock(...);...
29

妥快扼找我把批快技抉忱扶抉扭抉志快忱快扶我快
孚抉把抉扮抉
...
XCTAssertTrue(viewReloaded);
XCTAssertTrue(newDataIsShown);
妤抖抉抒抉
...
XCTAssertTrue(newUserSaved);
XCTAssertFalse(viewReloaded);
XCTAssertNil([self.service obtainSearchHistory]);
30

OCMExpect([self.mockView setupInitialStateWithMenuItems:[OCMArg checkWithBlock:^BOOL(NSArray
*menuItems) {
__block BOOL correctSelectors = YES;
[menuItems enumerateObjectsUsingBlock:^(ItemViewModel *menuItem, NSUInteger idx, BOOL stop) {
NSString *expectedSelector = selectors[idx];
if (![expectedSelector isEqualToString:NSStringFromSelector(menuItem.tapSelector)]) {
correctSelectors = NO;
}
}];
return correctSelectors && menuItems.count == selectors.count;
}]]);
31

OCMExpect([self.mockView setupInitialStateWithMenuItems:[OCMArg checkWithBlock:^BOOL(NSArray
*menuItems) {
__block BOOL correctSelectors = YES;
[menuItems enumerateObjectsUsingBlock:^(ItemViewModel *menuItem, NSUInteger idx, BOOL stop) {
NSString *expectedSelector = selectors[idx];
if (![expectedSelector isEqualToString:NSStringFromSelector(menuItem.tapSelector)]) {
correctSelectors = NO;
}
}];
return correctSelectors && menuItems.count == selectors.count;
}]]);
self.mockView = [MockMenuView new];
XCTAssertTrue(self.mockView.areAllSelectorsCorrect);
32

// 妊抖批折忘抄扶忘攸扼找把抉抗忘
NSString *string = [[NSUUID UUID] UUIDString];
// 妤把抉我戒志抉抖抆扶忘攸抉扮我忌抗忘
NSError *error = [NSError errorWithDomain:@"TestDomain" code:0 userInfo:nil];
33

// 妊抖批折忘抄扶忘攸扼找把抉抗忘
NSString *string = [[NSUUID UUID] UUIDString];
// 妤把抉我戒志抉抖抆扶忘攸抉扮我忌抗忘
NSError *error = [NSError errorWithDomain:@"TestDomain" code:0 userInfo:nil];
NSString *string = [MockGenerator generateMockString];
NSError *error = [MockGenerator generateMockError];
34

- (void)setUp {
[super setUp];
RamblerInitialAssemblyCollector *collector = [RamblerInitialAssemblyCollector new];
NSArray *assemblyClasses = [collector collectInitialAssemblyClasses];
NSMutableArray *collaboratingAssemblies = [NSMutableArray array];
for (Class assemblyClass in assemblyClasses) {
if (assemblyClass == [NetworkAssembly class]) {
continue;
}
TyphoonAssembly *assembly = [assemblyClass new];
[collaboratingAssemblies addObject:assembly];
}
NetworkAssembly *networkAssembly = [NetworkAssembly new];
[networkAssembly activateWithCollaboratingAssemblies:collaboratingAssemblies];
[networkAssembly inject:self];
}
35

- (void)setUp {
[super setUp];
RamblerInitialAssemblyCollector *collector = [RamblerInitialAssemblyCollector new];
NSArray *assemblyClasses = [collector collectInitialAssemblyClasses];
NSMutableArray *collaboratingAssemblies = [NSMutableArray array];
for (Class assemblyClass in assemblyClasses) {
if (assemblyClass == [NetworkAssembly class]) {
continue;
}
TyphoonAssembly *assembly = [assemblyClass new];
[collaboratingAssemblies addObject:assembly];
}
NetworkAssembly *networkAssembly = [NetworkAssembly new];
[networkAssembly activateWithCollaboratingAssemblies:collaboratingAssemblies];
[networkAssembly inject:self];
[MagicalRecord setupInMemoryCoreData];
}
- (void)setUp {
[self setUpWithAssemblyClass:[NetworkAssembly class]];
}
36

- (void)testThatServiceLoadsSessionProfileSuccessfully {
NSError *resultError;
// 忌抉抖抆扮抉抄忌抖抉抗抖抉忍我抗我戒忘忍把批戒抗我扭把抉扳我抖攸
XCTAssertNil(resultError);
}
- (void)testThatServiceLoadsSessionProfileWithError {
NSError *expectedError = [MockObjectsFactory generateGeneralError];
XCTAssertEqualObjects(resultError, expectedError);
}
37

- (void)testThatServiceLoadsSessionProfileSuccessfully {
NSError *resultError;
XCTAssertNil(resultError);
}
- (void)testThatServiceLoadsSessionProfileWithError {
NSError *expectedError = [MockObjectsFactory generateGeneralError];
XCTAssertEqualObjects(resultError, expectedError);
}
- (void)testThatServiceLoadsProfileSuccessfully {
[self verifyThatServiceLoadsProfileWithError:nil];
}
- (void)testThatServiceLoadsProfileWithError {
[self verifyThatServiceLoadsProfileWithError:error];
}
- (void)verifyThatServiceLoadsProfileWithError:(id)error {
...
}
38

- (void)testThatPresenterStartsObservePost {
NSString *postId = [MockObjectsFactory generateGeneralString];
[self.presenter configureCurrentModuleWithPostId:postId];
[self.presenter didTriggerViewReadyEvent];
OCMVerify([self.mockInteractor startObserveChangesWithPostId:postId]);
}
39

}
// given
// when
// then
}
40

41

OperationScheduler
queue1 queue2
NSOperation NSOperation
42

NSArray *operations = self.generalQueue.operations;
for (NSOperation *generalOperation in operations) {
[generalOperation addDependency:operation];
}
[self.authQueue addOperation:operation];
43

? 妤快把快忱忘快技 initialOperation 志妤抖忘扶我把抉志投我抗
? 妤快把快忱忘快技志妤抖忘扶我把抉志投我抗 5 generalOperation
? 妤把我志抑扭抉抖扶快扶我我 initialOperation 扼抉戒忱忘快找 authOperation
initial > authorization > general (5x)
44

- (void)testThatAuthOperationBlocksGeneralOperations {
// given
XCTestExpectation *expectation = [self expectationForCurrentTest];
NSMutableArray *operationNames = [NSMutableArray array];
NSString *const kAuthOperationName = @"AuthOperation";
NSString *const kInitialOperationName = @"InitialOperation";
NSString *const kGeneralOperationName = @"GeneralOperation";
NSUInteger const kGeneralOperationsCount = 5;
__block NSNumber *operationCounter = @0;
NSBlockOperation *authOperation = [NSBlockOperation blockOperationWithBlock:^{
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
@synchronized(operationNames) {
[operationNames addObject:kAuthOperationName];
}
[NSThread sleepForTimeInterval:0.05];
});
}];
NSBlockOperation *initialOperation = [NSBlockOperation blockOperationWithBlock:^{
[operationNames addObject:kInitialOperationName];
}
[self.scheduler addAuthOperation:authOperation];
}];
// when
[self.scheduler addGeneralOperation:initialOperation];
for (NSUInteger i = 0; i < kGeneralOperationsCount; i++) {
NSBlockOperation *generalOperation = [NSBlockOperation blockOperationWithBlock:^{
[operationNames addObject:kGeneralOperationName];
}
@synchronized(operationCounter) {
operationCounter = @([operationCounter integerValue] + 1);
if ([operationCounter integerValue] == kGeneralOperationsCount) {
dispatch_async(dispatch_get_main_queue(), ^{
});
}
}
}];
[self.scheduler addGeneralOperation:generalOperation];
}
// then
[self waitForExpectationsWithTimeout:kTestExpectationTimeout handler:^(NSError *error) {
XCTAssertEqualObjects(operationNames[0], kInitialOperationName);
XCTAssertEqualObjects(operationNames[1], kAuthOperationName);
for (NSUInteger i = 2; i < kGeneralOperationsCount; i++) {
XCTAssertEqualObjects(operationNames[i], kGeneralOperationName);
}
}];
}
45

XCTestExpectation *expectation =
[self expectationWithDescription:@"Last operation fired"];
XCTestExpectation *expectation =
[self expectationForCurrentTest];
46

NSString *const kAuthOperationName = @"AuthOperation";
NSString *const kInitialOperationName = @"InitialOperation";
NSString *const kGeneralOperationName = @"GeneralOperation";
OperationSchedulerTestConstants.h
47

NSBlockOperation *authOperation = [NSBlockOperation withBlock:^{
dispatch_async(..., ^{
[operationNames addObject:authName];
}
[NSThread sleep:0.05];
});
}];
48

@interface TestBlockingByAuthOperationEnvironment : NSObject
- (void)setupWithTestCase:(XCTestCase *)testCase
operationsCount:(NSUInteger)operationsCount
initialBlock:(Block)initialBlock;
@property NSBlockOperation *initialOperation;
@property NSBlockOperation *authOperation;
@property NSArray *generalOperations;
@property NSArray *firedOperationNames;
@end
49

TestBlockingByAuthOperationEnvironment *environment =
[TestBlockingByAuthOperationEnvironment new];
[environment setupWithTestCase:self
operationsCount:kGeneralOperationsCount
initialBlock:^{
[self.scheduler addAuthOperation:environment.authOperation];
for (NSOperation *operation in environment.generalOperations) {
[self.scheduler addGeneralOperation:operation];
}
}];
50

- (void)testThatAuthOperationBlocksGeneralOperations {
// given
NSUInteger const kGeneralOperationsCount = 5;
TestBlockingByAuthOperationEnvironment *environment = [TestBlockingByAuthOperationEnvironment new];
[environment setupEnvironmentWithTestCase:self
generalOperationsCount:kGeneralOperationsCount
initialOperationBlock:^{
[self.scheduler addAuthOperation:environment.authOperation];
for (NSOperation *operation in environment.generalOperations) {
[self.scheduler addGeneralOperation:operation];
}
}];
// when
[self.scheduler addGeneralOperation:environment.initialOperation];
// then
[self waitForExpectationsWithTimeout:kTestExpectationTimeout handler:^(NSError *error) {
[self verifyCorrectOperationOrder:kTestOrder];
}];
}
51

妤把快忱技快找扶抉-抉把我快扶找我把抉志忘扶扶抑抄攸戒抑抗
妖快找抖我扮扶快忍抉抗抉扶找快抗扼找忘
妥快扼找我把批快技抉忱扶抉扭抉志快忱快扶我快
52

What makes a clean test?
Three things.
Readability, readability,
and readability.
圻忍抉把妥抉抖扼找抉抄
@igrekde

端端舝

Rambler.iOS #8: 完我扼找抑快 unit-找快扼找抑

Recommended

More Related Content

What's hot (20)

Viewers also liked (6)

More from RAMBLER&Co (20)

Rambler.iOS #8: 完我扼找抑快 unit-找快扼找抑