??? ?? ????
18 likes2,307 views
The document outlines a code review process detailing various statuses such as 'needs review', 'accepted', and 'abandoned'. It includes references to APIs, integration, and provides tips for effective code review practices. Additionally, it mentions various acronyms and links to related resources on Github.
![1. .
Tips!
1. "[ ] " .
2. .
3. , .
:](https://image.slidesharecdn.com/codereviewv2-190708104710/85/-34-320.jpg)
??? ?? ????
- 1. Code Review2
- 3. ~
- 4. ~
- 6. -> -> -> Github -> Phabricator -> Time zone -> timezone
- 7. :
- 8. ...
- 9. ...
- 10. ...
- 12. / / w a r n i n g / / (team by team)
- 13. ( " " )
- 15. Review Status In Preparation - . . Needs review - . Needs revision - . Change plans - . . Abandoned - . Accepted - ! .
- 16. Review Status In Preparation - Needs review - Needs revision - Change plans - Abandoned - Nil Accepted - Blocker of each status
- 17. Review Status In Preparation - Needs review - Needs revision - Change plans - Abandoned - Nil Accepted - Blocker of each status . <-
- 20. Review dependency master (1/4) (2/4) (3/4) (4/4) needs review accepted needs revision needs review
- 21. Review dependency master (1/4) (2/4) (3/4) (4/4) needs review accepted needs revision needs review <- (1/4) (release)
- 23. Review dependency master (1/4) (2/4) (3/4) (4/4) API API Front (1) - Front (2) -
- 25. ...?
- 27. 1. .
- 28. ... 1. .
- 29. 1. . . .
- 30. 1. . , .
- 31. 1. . ???
- 32. 1. . , . , . :
- 33. 1. . ( ) . . . :
- 34. 1. . Tips! 1. "[ ] " . 2. . 3. , . :
- 35. 2. (integration) . . - " "
- 36. 2. CI . .
- 37. 2. test
- 38. 2. ! !
- 40. 3. " " .
- 41. 3. ?
- 42. 3. , Controller . A 1 B New Controller Utility.someFunction() return Some Response; onClick refresh ( ) ... ( 1 )
- 43. 3. , Blame .
- 44. 4. , . . . . ( , )
- 46. 4. 1. "You" . . , "We" . We can do this way instead of that way. 2. / . "This variable name is extremely vague" . 3. . "THAT IS NOT RIGHT"
- 47. 4. ! ! .
- 48. 4. 1. 2. 3.
- 49. . , . , . . . .
- 50. . ( ) ( ) - WIP : Work in Progress / : https://github.com/serverless/serverless/pull/4796
- 51. . ( ) ( ) - RFC : Request for comment / : https://github.com/serverless/examples/pull/162
- 52. . ( ) ( ) - TY : Thank You! / : https://github.com/facebookincubator/fbt/pull/20
- 53. . ( ) ( ) - LGTM : Looks good to me / nit : nit-pick / (?) : https://github.com/babel/babel/pull/9144